New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beat velocities are not shown correctly on the classic theme #3226

Closed
Umcaruje opened this Issue Jan 9, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@Umcaruje
Member

Umcaruje commented Jan 9, 2017

image
Problem introduced by #2960. The graphics for the classic theme should be updated.

Noticed by @karmux in #3225 (comment)

@Umcaruje Umcaruje added bug gui labels Jan 9, 2017

@Umcaruje Umcaruje added this to the 1.2.0 milestone Jan 9, 2017

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jan 9, 2017

Member

Also, what that PR introduced is the inability to distinguish steps with 0 velocity and no steps:
image

which existed in 1.1.3:
image

Member

Umcaruje commented Jan 9, 2017

Also, what that PR introduced is the inability to distinguish steps with 0 velocity and no steps:
image

which existed in 1.1.3:
image

@SirBothersome

This comment has been minimized.

Show comment
Hide comment
@SirBothersome

SirBothersome Jan 9, 2017

@Umcaruje ,This may be build-related, per #3225 Perhaps try restarting?

SirBothersome commented Jan 9, 2017

@Umcaruje ,This may be build-related, per #3225 Perhaps try restarting?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jan 9, 2017

Member

@SirBothersome No. In 1.2 we have 2 official themes, classic and default. Classic was broken by the mentioned Pull Request.

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

Member

Umcaruje commented Jan 9, 2017

@SirBothersome No. In 1.2 we have 2 official themes, classic and default. Classic was broken by the mentioned Pull Request.

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

@SirBothersome

This comment has been minimized.

Show comment
Hide comment
@SirBothersome

SirBothersome Jan 9, 2017

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

@Umcaruje , 3 actually, but all were installed in separate directories... I get what you're saying tho. The thing is, volume sensitivity was no longer broken..

SirBothersome commented Jan 9, 2017

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

@Umcaruje , 3 actually, but all were installed in separate directories... I get what you're saying tho. The thing is, volume sensitivity was no longer broken..

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Jan 9, 2017

Member

volume sensitivity was no longer broken..

Because you were using the new theme.

Member

Umcaruje commented Jan 9, 2017

volume sensitivity was no longer broken..

Because you were using the new theme.

@karmux

This comment has been minimized.

Show comment
Hide comment
@karmux

karmux Jan 9, 2017

Contributor

I'm working on a fix that includes difference between 0 velocity and no step.

Contributor

karmux commented Jan 9, 2017

I'm working on a fix that includes difference between 0 velocity and no step.

@karmux

This comment has been minimized.

Show comment
Hide comment
@karmux

karmux Jan 9, 2017

Contributor

ebf0063 is correct and I created PR #3229 on that. I deleted branch of first commit but commit still exists...

Contributor

karmux commented Jan 9, 2017

ebf0063 is correct and I created PR #3229 on that. I deleted branch of first commit but commit still exists...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment