Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beat velocities are not shown correctly on the classic theme #3226

Closed
Umcaruje opened this issue Jan 9, 2017 · 7 comments
Closed

Beat velocities are not shown correctly on the classic theme #3226

Umcaruje opened this issue Jan 9, 2017 · 7 comments
Labels
bug gui
Milestone
1.2.0

Comments

@Umcaruje
Copy link
Member

Umcaruje commented Jan 9, 2017

image
Problem introduced by #2960. The graphics for the classic theme should be updated.

Noticed by @karmux in #3225 (comment)
@Umcaruje Umcaruje added this to the 1.2.0 milestone Jan 9, 2017
@Umcaruje
Copy link
Member Author

Umcaruje commented Jan 9, 2017

Also, what that PR introduced is the inability to distinguish steps with 0 velocity and no steps:
image

which existed in 1.1.3:
image

@SirBothersome
Copy link

@Umcaruje ,This may be build-related, per #3225 Perhaps try restarting?

@Umcaruje
Copy link
Member Author

Umcaruje commented Jan 9, 2017

@SirBothersome No. In 1.2 we have 2 official themes, classic and default. Classic was broken by the mentioned Pull Request.

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

@SirBothersome
Copy link

SirBothersome commented Jan 9, 2017 •
edited
Loading

The issue you had was that LMMS was using a left-over theme from LMMS 1.1 since you probably installed 2 versions side by side.

@Umcaruje , 3 actually, but all were installed in separate directories... I get what you're saying tho. The thing is, volume sensitivity was no longer broken..

@Umcaruje
Copy link
Member Author

Umcaruje commented Jan 9, 2017

volume sensitivity was no longer broken..

Because you were using the new theme.

@karmux
Copy link
Contributor

karmux commented Jan 9, 2017

I'm working on a fix that includes difference between 0 velocity and no step.

@karmux
Copy link
Contributor

karmux commented Jan 9, 2017 •
edited
Loading

ebf0063 is correct and I created PR #3229 on that. I deleted branch of first commit but commit still exists...

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@karmux @zonkmachine
Fixed LMMS#3226. Beat velocity fixes for both themes. (LMMS#3229)
65e6654 
* Fixed LMMS#3226. Fixed beat velocity on classic theme. Fixed visual difference between 0 velocity and no step.

* Render step_btn_on_0.png always.

* Removed useless if.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug gui
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@karmux @Umcaruje @SirBothersome