-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some MIDI events(ex. sustain pedal) should be ignored while exporting #3747
Comments
You don't need to export the project. Swap step 4 above with, |
Even more crazy thing: If you press keys from your MIDI keyboard while exporting, they will be rendered. |
Tbh all midi events should be completely ignored while exporting. I had to re-render a lot of times when I actually accidentally pressed some keys on my midi keyboard while exporting |
So, something like this... void InstrumentTrack::processInEvent( ... )
{
if( Engine::getSong()->isExporting() )
{
return;
}
...
Edit: Code above works but doesn't cover notes/events in effect before exporting. |
I pulled the above code in #3778. It's a partial fix and a good compromise for 1.2.0 . |
To reproduce:
Result: sustain pedal affects to the export, which is undesirable.
Tested with latest master.
The text was updated successfully, but these errors were encountered: