Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some MIDI events(ex. sustain pedal) should be ignored while exporting #3747

Open
PhysSong opened this issue Aug 3, 2017 · 5 comments
Open

Comments

@PhysSong
Copy link
Member

PhysSong commented Aug 3, 2017

To reproduce:

  1. Enable MIDI input in instrument window.
  2. Put some notes.
  3. Hold sustain pedal.
  4. Export project.

Result: sustain pedal affects to the export, which is undesirable.
Tested with latest master.

@zonkmachine
Copy link
Member

You don't need to export the project. Swap step 4 above with, 4. Play project.
This behaviour is already there in 1.0.3

@PhysSong
Copy link
Member Author

PhysSong commented Aug 3, 2017

Even more crazy thing: If you press keys from your MIDI keyboard while exporting, they will be rendered.

@Umcaruje
Copy link
Member

Umcaruje commented Aug 8, 2017

Tbh all midi events should be completely ignored while exporting. I had to re-render a lot of times when I actually accidentally pressed some keys on my midi keyboard while exporting

@zonkmachine
Copy link
Member

zonkmachine commented Aug 8, 2017

So, something like this...

void InstrumentTrack::processInEvent( ... )
{
    if( Engine::getSong()->isExporting() )
    {
        return;
    }
...

Edit: Code above works but doesn't cover notes/events in effect before exporting.

@zonkmachine
Copy link
Member

I pulled the above code in #3778. It's a partial fix and a good compromise for 1.2.0 .

@Sawuare Sawuare removed the ux label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants