Zyn causes audio to cut out on MacOS #4152
Comments
|
Changed bug to running-list of built-in presets. Edit: Got a backtrace, I think. BacktraceI think the relevant part in the backtrace is... |
|
I can confirm that putting a Some unit tests:
Code to circumvent the audio cut-out:
void LocalZynAddSubFx::processAudio( sampleFrame * _out )
{
float outputl[synth->buffersize];
float outputr[synth->buffersize];
m_master->GetAudioOutSamples( synth->buffersize, synth->samplerate, outputl, outputr );
+ for (int i = 0; i < synth->buffersize; ++i ) {
+ if (nan(outputl[i])) outputl[i] = 0;
+ if (nan(outputr[i])) outputr[i] = 0;
+ }
// TODO: move to MixHelpers
for( int f = 0; f < synth->buffersize; ++f )
{
_out[f][0] = outputl[f];
_out[f][1] = outputr[f];
}
}But it gets stranger... turns out This isn't true for all presets either. |
|
I guess it is related to undefined behavior of |
|
Detailed explanation... lmms/plugins/zynaddsubfx/zynaddsubfx/src/Synth/OscilGen.cpp Lines 607 to 608 in b4e7806 In such cases, Zyn passes negative number for the first parameter of std::polar. It will lead to undefined behavior.lmms/plugins/zynaddsubfx/zynaddsubfx/src/Synth/OscilGen.cpp Lines 632 to 634 in b4e7806 So I guess this is a issue with runtime library rather than Qt. |
tresf
added a commit
to tresf/lmms
that referenced
this issue
Mar 18, 2018
Cherry-pick of upstream 2.5 patch: zynaddsubfx/zynaddsubfx@417d49b Closes LMMS#4152
tresf
added a commit
that referenced
this issue
Mar 18, 2018
Fix C++ standards library portability issue. Cherry-pick of upstream 2.5 patches: zynaddsubfx/zynaddsubfx@417d49b, zynaddsubfx/zynaddsubfx@edca8ab Closes #4152
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this issue
Jun 28, 2022
Fix C++ standards library portability issue. Cherry-pick of upstream 2.5 patches: zynaddsubfx/zynaddsubfx@417d49b, zynaddsubfx/zynaddsubfx@edca8ab Closes LMMS#4152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Edit: This is a running list of built-in presets that cause audio-cut out on MacOS and eventually find out why it happens.
presets/ZynAddSubFX/the_mysterious_bank_2/0037-ufo2.xizpresets/ZynAddSubFX/Arpeggios/0009-Arpeggio9.xizThe text was updated successfully, but these errors were encountered: