Proposed fix for issue 1432 LB302 preset preview audio cut-off #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix confirmed. @diizy Since you have worked with this code a bit, could you take a look at the proposed change? |
|
Hm, hard to say - does the playback work as expected in non-preview situations? |
|
Yes it does. |
|
Merging so that we can close out the bug and get this into RC11. Will revert and reopen if needed. |
tresf
added a commit
that referenced
this pull request
Dec 16, 2014
Proposed fix for issue 1432 LB302 preset preview audio cut-off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed fix for #1432
Appears to be working, I am not overly familiar with this plugin