Give focus to the PianoRoll widget when its window is opened #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresf
added a commit
that referenced
this pull request
Apr 19, 2015
Give focus to the PianoRoll widget when its window is opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the feature requested in #1972. Whenever focus is given to the piano roll window (but not one of its children), focus is passed onto the actual piano roll widget too. This way, whenever the window bar is clicked, or when another part of the program calls
gui->pianoRoll()->setFocus(), the actual piano roll widget will be able to receive keyboard events, etc.This code could be applied to the BB and Automation Editors as well, but I didn't see any benefit to that at this point so I left it out for simplicity.