Redesign of EQ plugin #3030

BaraMGB · 2016-09-10T13:08:17Z

suggestions?

RebeccaDeField · 2016-09-10T17:39:45Z

A couple of ideas/questions 😄 :

Would it be possible to lighten the green grid a bit to increase the contrast?

I'm also wondering if we can change the colors on the graph such as the red and yellow to colors that might blend and overlap especially well, but I don't want to disturb the technical accuracy of the colors that are already in place if there is a specific reason for them being what they are.

I would also love to see the numbers that are not selected in white instead of black.

Great work! 👍

BaraMGB · 2016-10-20T11:31:54Z

@RebeccaDeField

I would also love to see the numbers that are not selected in white instead of black.

done

I'm also wondering if we can change the colors on the graph such as the red and yellow to colors that might blend and overlap especially well

can you make a rough mockup?

Would it be possible to lighten the green grid a bit to increase the contrast?

I want to wait for @LocoMatt to match the design to his "Dynamics Processor" design.

RebeccaDeField · 2016-10-21T01:02:10Z

@BaraMGB

done

Thank you 👏

can you make a rough mockup?

When muted reds and yellows overlap they can have a tendency to look a bit muddy, whereas combos like purple+blue, green+blue might look really well together.

This is a very very rough mockup

Other examples:

I want to wait for @LocoMatt to match the design to his "Dynamics Processor" design.

Sounds good 👍

Umcaruje · 2016-11-11T21:13:01Z

@BaraMGB LocoMatt probably won't be contributing anymore, so can you please proceed with the redesign. The current waveshaper redesign idea looks like this: #3097 (comment) so you could adjust the grid to that

BaraMGB · 2016-11-15T10:15:20Z

Spekular · 2016-11-15T10:35:09Z

I think it looks a bit odd to have a separate frame around each band, at least when there's so much contrast between the bands and the background.

Umcaruje · 2016-11-15T10:37:39Z

@BaraMGB do we do antialising on the FFT graph? looks a bit jagged to me. Also I think you should update the faders so they reflect the new fader redesign.

RebeccaDeField · 2016-11-15T18:38:33Z

@Umcaruje Summed up everything I was going to say 😉

BaraMGB · 2016-11-15T19:56:19Z

@Spekular which frame do you mean? The gray rectangle under the Knobs and faders? There are so many controls in this plugin. I think the eyes needs some guide to see which things belong together.

Spekular · 2016-11-15T20:36:55Z

@BaraMGB yeah the knobs and faders. I agree they should be outlined/separated somehow, but it feels "busy" to me to have them stand out so much from the flat background. I think if the contrast between colors in the bg and foreground were lower it might be better.

That being said, nobody else has mentioned it so it could be just me.

IvanMaldonado · 2016-11-15T20:51:51Z

What about reducing the borders a bit and making the graph wider to save some space?

Spekular · 2016-11-15T22:24:34Z

That looks really good imo!

BaraMGB · 2016-11-16T09:13:59Z

That looks good to me, too. But, @Spekular, is this a solution for your objections?

Spekular · 2016-11-16T10:56:36Z

@BaraMGB yeah, somehow I mind the borders less now.

RebeccaDeField · 2016-11-17T21:14:27Z

@BaraMGB I like @IvanMaldonado's idea as well 👍

BaraMGB · 2016-11-18T08:52:03Z

Okay, then. I'll adjust the layout.

BaraMGB · 2017-01-13T13:59:17Z

Okay, months later:

@RebeccaDeField @Umcaruje @Spekular @IvanMaldonado opinions?

Spekular · 2017-01-13T14:23:10Z

Looks great imo :) I've got no objections.

RebeccaDeField · 2017-01-13T18:54:51Z

@BaraMGB this is looking fantastic! It does seems that for some reason, the design is using an older version of the fader leds.

BaraMGB · 2017-01-13T19:00:00Z

the design is using an older version of the fader leds.

@RebeccaDeField umcaruje is working on this. ;)

Umcaruje · 2017-01-13T19:00:09Z

@RebeccaDeField I'm on that, going to make some fresh fader graphics for the eq.

Umcaruje · 2017-01-13T19:00:33Z

Ninja'd lol

Umcaruje · 2017-01-14T21:05:54Z

Here's how it looks with the new faders.

BaraMGB · 2017-01-14T21:23:38Z

I think it's ready, finally.

zonkmachine · 2017-01-15T12:11:42Z

It looks amazing. I think it looked just a bit better with a gradual change on the fader leds. haven't seen it in motion though. Merge anytime. :)

BaraMGB · 2017-01-18T09:04:31Z

I finally figured how these fader peaks works. There were two little bugs. And for the shelving filters I choose new values so they are more useful I think. Actually they aren't useful because we have the analyzing graph. But we have the faders so they should work useful in any way.

If there are no objections anymore this can be merged.

Umcaruje · 2017-01-18T23:39:27Z

@BaraMGB since the weird value happening in the faders are gone now, could you try switching them out to render in dB and see how it goes? I'm willing to make new graphics if you make the switch, when I finish my schoolwork.

Umcaruje · 2017-01-18T23:50:36Z

Oh and Just to mention it, I don't know what you exactly changed in the shelving filters, but they don't usually have a resonance, at least not in the EQ's I've used. The problem is when you accidentaly tweak the resonance it starts really getting a huge spike in the curve and I'm not sure many people could find it useful, so maybe the resonance knob's range could be reduced for the shelving filters, so there's a more fine-tuned approach?

zapashcanon · 2017-01-19T18:33:43Z

plugins/Eq/EqEffect.cpp

-			peakBand( 0,
-					  m_eqControls.m_lowShelfFreqModel.value(), fft , samplerate );
+			peakBand( m_eqControls.m_lowShelfFreqModel.value()
+					  - ( m_eqControls.m_lowShelfFreqModel.value() * m_eqControls.m_lowShelfResModel.value() * 0.5 ),


Freq.value * (2 - Res.value) / 2

To avoid one call to Freq.value ;)

zapashcanon · 2017-01-19T18:36:05Z

plugins/Eq/EqEffect.cpp

@@ -397,7 +399,9 @@ void EqEffect::setBandPeaks(EqAnalyser *fft, int samplerate )

 	m_eqControls.m_highShelfPeakL = m_eqControls.m_highShelfPeakR =
 			peakBand( m_eqControls.m_highShelfFreqModel.value(),
-					  samplerate * 0.5 , fft, samplerate );
+					  m_eqControls.m_highShelfFreqModel.value()
+					  + ( m_eqControls.m_highShelfFreqModel.value() * m_eqControls.m_highShelfResModel.value() * 0.5 ),


Same here:

Freq.value * (2 + Res.value) / 2

zapashcanon · 2017-01-19T18:47:16Z

plugins/Eq/EqCurve.cpp

-
-		painter->drawPixmap( -12, -12, PLUGIN_NAME::getIconPixmap( "handlehover" ) );
+		QPixmap hover = PLUGIN_NAME::getIconPixmap( "handlehover" );
+		painter->drawPixmap( 0 - ( hover.width() / 2) - 1, 0 - ( hover.height() / 2 ), hover );


painter->drawPixmap( - hover.width() / 2 - 1, - hover.height() / 2, hover );

Why not removing the 0 ?

zapashcanon · 2017-01-19T18:49:10Z

plugins/Eq/EqCurve.cpp

-	painter->drawPixmap( -12, -12, circlePixmap );
+	// graphics for the handles
+	loadPixmap();
+	painter->drawPixmap( 0 - ( m_circlePixmap.width() / 2 ) - 1 , 0 - ( m_circlePixmap.height() / 2 ), m_circlePixmap );


painter->drawPixmap( - m_circlePixmap.width() / 2 - 1, - m_circlePixmap.height() / 2, m_circlePixmap );

Why not removing the 0 ?

zapashcanon · 2017-01-19T18:49:43Z

plugins/Eq/EqCurve.cpp

@@ -49,15 +49,15 @@ EqHandle::EqHandle( int num, int x, int y )	:

 QRectF EqHandle::boundingRect() const
 {
-	return QRectF( -11, -11, 23, 23 );
+	return QRectF( 0 - m_circlePixmap.width() / 2, 0 - m_circlePixmap.height() / 2, m_circlePixmap.width(), m_circlePixmap.height() );


return QRectF( - m_circlePixmap.width() / 2, - m_circlePixmap.height() / 2, m_circlePixmap.width(), m_circlePixmap.height() );

Why not removing the 0 ?

zapashcanon · 2017-01-19T18:51:26Z

plugins/Eq/EqControlsDialog.cpp

@@ -161,79 +131,66 @@ EqControlsDialog::EqControlsDialog( EqControls *controls ) :
 		QObject::connect( m_parameterWidget->getBandModels( i )->active, SIGNAL( dataChanged() ), m_parameterWidget , SLOT ( updateHandle() ) );

 		m_parameterWidget->changeHandle( i );
+		distance = distance + 44;


distance += 44;

Easier to read IMHO.

Same on line 91.

@zapashcanon

* redesign of EQ plugin * correct some symbols * set pixelPerUnitHeight to float * change textcolor of inactive handles to white * revert changes in styles.css * change grid color/adjust Fontsize of info box / change analizing color * range changed (20 - 20000 Hz) / display width increased * Update the EQ faders and remove unused files * Increase transparency of the graph * corrects the filter fader peak * makes fader peak display more useful * Implement @zapashcanon's suggestions

redesign of EQ plugin

40f2ac7

Umcaruje added the in progress label Sep 10, 2016

RebeccaDeField added the gui label Sep 11, 2016

RebeccaDeField mentioned this pull request Sep 15, 2016

Redesign The Effects Plugins #2831

Closed

14 tasks

BaraMGB force-pushed the equalizerredesign branch from a6e6b9f to 40f2ac7 Compare October 17, 2016 12:05

BaraMGB added 4 commits October 20, 2016 11:52

merge master

55122d9

correct some symbols

c5ff4c9

set pixelPerUnitHeight to float

324faf7

change textcolor of inactive handles to white

59febf9

revert changes in styles.css

bfb508e

BaraMGB added 2 commits November 15, 2016 10:50

change grid color/adjust Fontsize of info box / change analizing color

5787f7b

rebase to master

7d419f3

range changed (20 - 20000 Hz) / display width increased

22764de

Update the EQ faders and remove unused files

3448c09

Increase transparency of the graph

c26a127

BaraMGB added 2 commits January 15, 2017 15:28

corrects the filter fader peak

842b54a

makes fader peak display more useful

a59059a

zapashcanon suggested changes Jan 19, 2017

View reviewed changes

Umcaruje mentioned this pull request Feb 7, 2017

**Equalizer** has flicker default #3336

Closed

Implement @zapashcanon's suggestions

2af211c

Umcaruje removed the in progress label Feb 14, 2017

Umcaruje changed the title ~~[wip] redesign of EQ plugin~~ Redesign of EQ plugin Feb 14, 2017

BaraMGB merged commit 558962d into LMMS:master Feb 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign of EQ plugin #3030

Redesign of EQ plugin #3030

BaraMGB commented Sep 10, 2016

RebeccaDeField commented Sep 10, 2016 •

edited

Loading

BaraMGB commented Oct 20, 2016

RebeccaDeField commented Oct 21, 2016 •

edited

Loading

Umcaruje commented Nov 11, 2016

BaraMGB commented Nov 15, 2016

Spekular commented Nov 15, 2016

Umcaruje commented Nov 15, 2016

RebeccaDeField commented Nov 15, 2016

BaraMGB commented Nov 15, 2016

Spekular commented Nov 15, 2016

IvanMaldonado commented Nov 15, 2016

Spekular commented Nov 15, 2016

BaraMGB commented Nov 16, 2016

Spekular commented Nov 16, 2016

RebeccaDeField commented Nov 17, 2016

BaraMGB commented Nov 18, 2016

BaraMGB commented Jan 13, 2017

Spekular commented Jan 13, 2017

RebeccaDeField commented Jan 13, 2017

BaraMGB commented Jan 13, 2017

Umcaruje commented Jan 13, 2017

Umcaruje commented Jan 13, 2017

Umcaruje commented Jan 14, 2017

BaraMGB commented Jan 14, 2017

zonkmachine commented Jan 15, 2017

BaraMGB commented Jan 18, 2017

Umcaruje commented Jan 18, 2017

Umcaruje commented Jan 18, 2017

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

Redesign of EQ plugin #3030

Redesign of EQ plugin #3030

Conversation

BaraMGB commented Sep 10, 2016

RebeccaDeField commented Sep 10, 2016 • edited Loading

BaraMGB commented Oct 20, 2016

RebeccaDeField commented Oct 21, 2016 • edited Loading

Umcaruje commented Nov 11, 2016

BaraMGB commented Nov 15, 2016

Spekular commented Nov 15, 2016

Umcaruje commented Nov 15, 2016

RebeccaDeField commented Nov 15, 2016

BaraMGB commented Nov 15, 2016

Spekular commented Nov 15, 2016

IvanMaldonado commented Nov 15, 2016

Spekular commented Nov 15, 2016

BaraMGB commented Nov 16, 2016

Spekular commented Nov 16, 2016

RebeccaDeField commented Nov 17, 2016

BaraMGB commented Nov 18, 2016

BaraMGB commented Jan 13, 2017

Spekular commented Jan 13, 2017

RebeccaDeField commented Jan 13, 2017

BaraMGB commented Jan 13, 2017

Umcaruje commented Jan 13, 2017

Umcaruje commented Jan 13, 2017

Umcaruje commented Jan 14, 2017

BaraMGB commented Jan 14, 2017

zonkmachine commented Jan 15, 2017

BaraMGB commented Jan 18, 2017

Umcaruje commented Jan 18, 2017

Umcaruje commented Jan 18, 2017

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

zapashcanon Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

RebeccaDeField commented Sep 10, 2016 •

edited

Loading

RebeccaDeField commented Oct 21, 2016 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading

zapashcanon Jan 19, 2017 •

edited

Loading