-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let sample tracks play from any song position #3133
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
025a8b4
play sampletracks from any song position
BaraMGB 849f063
take care of TCO length
BaraMGB a313ee7
TCOs shouldn't be updated when SE window is resized
BaraMGB 6ce7fed
take care of zooming level
BaraMGB df89f67
takes care on all song position changes and mute/solo tracks now
BaraMGB 1250eab
playes the sample only within the buffer limits
BaraMGB ae6c1ea
takes care of time signature changes
BaraMGB d784d75
some minor code improvements (zapashcanon)
BaraMGB b04f8b8
loopback one tick earlier
BaraMGB daf14a4
minor code changes
BaraMGB 5205f53
get rid off clicks by resize and scrolling song editor
BaraMGB 80db907
removes playhandle by remove TCO
BaraMGB bdc5c51
minor bugs on manipulating TCOs in Song Editor
BaraMGB 461a0e1
update on add sample by playing
BaraMGB 869890f
white spaces 1
BaraMGB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if( sampleStart < sampleBufferLength )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, sometimes I'm a little bit blind. ;)