Better message for missing sndio #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushuyu
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 3, 2017
Better message for missing sndio
liushuyu
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 19, 2017
Better message for missing sndio
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
Better message for missing sndio
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
Better message for missing sndio
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
Better message for missing sndio
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 7, 2017
Better message for missing sndio
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Better message for missing sndio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most platforms, OpenBSD's
sndiobackend doesn't display whether or not it has been found through cmake. This is because we echoSTATUS_SNDIOon each build, but we only set it on one platform.Initially, I had just enabled RoarAudio (adds
sdio.h) so we could test sndio via Ubuntu (via Travis). Unfortunately, RoarAudio won't compile, and it's not just us.So this PR is just cosmetic for the cmake configure step. Pinging @devnexen as FYI.
Note,
sndiois separate and not to be confused withlibsoundio.