Fix for misaligned controls icon in VeSTige plugin. #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhysSong
reviewed
Sep 21, 2017
| m_managePluginButton->setInactiveGraphic( PLUGIN_NAME::getIconPixmap( | ||
| "track_op_menu" ) ); | ||
| "controls" ) ); |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Fix for misaligned controls icon in VeSTige plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
track_op_menu* has different dimensions in classic theme and default theme. As track_op_menu* was only used in VeSTige and there's already identical theme icons under name trackop* then I decided to make it part of VeSTige. Just resizing or moving icons don't fix default theme while keeping classic theme as it is.
VeSTige in classic theme:
VeSTige in default theme before fix:
VeSTige in default theme after fix: