New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for misaligned controls icon in VeSTige plugin. #3664

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@karmux
Contributor

karmux commented Jun 24, 2017

track_op_menu* has different dimensions in classic theme and default theme. As track_op_menu* was only used in VeSTige and there's already identical theme icons under name trackop* then I decided to make it part of VeSTige. Just resizing or moving icons don't fix default theme while keeping classic theme as it is.

VeSTige in classic theme:

screenshot_20170624_213629

VeSTige in default theme before fix:

screenshot_20170624_213521

VeSTige in default theme after fix:

screenshot_20170624_230437

@tresf tresf merged commit 0abe0a5 into LMMS:stable-1.2 Jul 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
m_managePluginButton->setInactiveGraphic( PLUGIN_NAME::getIconPixmap(
"track_op_menu" ) );
"controls" ) );

This comment has been minimized.

@PhysSong

PhysSong Sep 21, 2017

Member

@karmux You should add two renamed images in BUILD_PLUGIN(), in plugins/VstEffect/CMakeLists.txt. I think changing logo.png to *.png will be fine.

@PhysSong

PhysSong Sep 21, 2017

Member

@karmux You should add two renamed images in BUILD_PLUGIN(), in plugins/VstEffect/CMakeLists.txt. I think changing logo.png to *.png will be fine.

This comment has been minimized.

@PhysSong

PhysSong Sep 24, 2017

Member

The problem was only in master. Now fixed via 4ca6cdb.

@PhysSong

PhysSong Sep 24, 2017

Member

The problem was only in master. Now fixed via 4ca6cdb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment