Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on exit from MIDI connections #4340

Merged
merged 1 commit into from May 8, 2018
Merged

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented May 4, 2018

Fixes #3357.

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 5, 2018

Tests fine! I can confirm the fix with the method to reproduce you described in issue comment here.

@Wallacoloo Wallacoloo self-requested a review May 6, 2018
@Wallacoloo Wallacoloo merged commit 03aa5fb into LMMS:stable-1.2 May 8, 2018
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PhysSong PhysSong deleted the PhysSong:midicrash branch May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.