Add sample track recording support #4531

PhysSong · 2018-08-09T01:08:45Z

This is the continuation of #3947 which has done by @Reflexe. Due to the merge conflict and some more reason, @lukas-w have rebased the original commits and pushed a new branch feature/recording.
You can contribute to this work by pushing commits to feature/recording or opening a pull request against this branch.
Thanks to @Reflexe for the work, @lukas-w for rebasing commits and many reviewers!

Bugs

TripleOscillator preset previews show errors and don't stop due to nonexistent samples/empty.wav
w2_invsinehalf.flac has a furry tail in BitInvader due to resampling(maybe an issue with Graph?)
Visualization gets weird when resizing tracks while recording

Enhancements

Reflexe · 2018-08-09T08:56:12Z

About the first one, I'm not sure how to do it. I think that the best way would be to just have an empty.wav. However, the current way of loading audio files returns empty data as a sign of failure.

About the second bug (re-sampling), would it be better to just drop automatic resampling (resampling higher to match the current output device) and stick with resampling on-the-fly?

About the third, I think I should implement an attribute for every track that "locks" it from the user. Track that's being recorded or manipulated in some way should not disappear (removed), resized or moved to another track, copied and so on.

Edit:

Fixed first issue here: #4536

I could not verify the second and the third issue for the latest feature/recording, I think i've fixed that already . It currently looks good to me. @karmux Could you verify it? Thank you.

About adding more backends: I'm not a fan of that idea since I've already tried it with PulseAudio and SDL and their behaviour were not consistent and had bugs so I've disabled them both in a few platforms. I think that focusing on one backend would help us debug and make sure we release a stable code.

Edit @PhysSong: removed old download links.

PhysSong · 2018-08-16T06:14:46Z

would it be better to just drop automatic resampling (resampling higher to match the current output device) and stick with resampling on-the-fly?

That's what we used to do. Resampling also makes some people can think LMMS hangs when exporting.

I think that focusing on one backend would help us debug and make sure we release a stable code.

Since this pull request targets to the development branch(unusual name master though), I think we don't need to concern about stability issues now.

LmmsBot · 2018-09-05T09:05:06Z

Downloads for this pull request

Linux: download.
Windows 32 Bit: download.
Windows 64 Bit: download.
Mac: download.

Generated by the LMMS pull requests bot.

PhysSong · 2018-09-18T01:35:58Z

Reminder: 18a7f28 and 88dca57 should be dropped once #4586 gets merged.

Reflexe · 2019-02-21T15:14:48Z

Do we want to merge it? I don't want this work to go to waste.
(All of the bugs has been fixed)

zonkmachine · 2019-02-24T11:06:18Z

(All of the bugs has been fixed)

Great! So what's left to do? Adding more backends and optimization?

Reflexe · 2019-02-24T11:11:16Z

Great! So what's left to do? Adding more backends and optimization?

IIRC, I worked a lot to optimize the recording and adding more backends is not that useful for now (Alsa is very different that Pulse and modern APIs).
The only thing left to do is maybe make the arming button more friendly (maybe a led, like the mute button).

PhysSong · 2019-02-24T11:48:42Z

I'll rebase commits against current master to produce newer test binaries.

tick 0)

audioPort as nullptr by default.

frames by the masterGain.

support.

SampleTCOs.

"played" (recorded).

SampleBuffer. That solves problem with recording that caused samples to be moved and messed up. Thanks @-BaraMGB for helping.

Previously, begining record in any position would result the data being in the end of the TCO. @see #3947 (comment) Thanks to @-BaraMGB :)

`updateMenu`, use a virtual function overriden by every Track implemetation.

input channel configurations. And support recording of one channel and converting it to two. The user would be able to set their input config per track, or globally. For each recorded sampletrack, the recorded will get the channel config and will duplicate the samples from one channel to the other in a case of mono input.

options unchecked will be considered as global default. Suggested by @-tresf, Thanks!

Fixes regression from f765773 (presumably a copy/paste mistake)

Thanks to @-PhysSong.

Fixes a regression in 84a1f35.

Fixes a regression in 7bc0056 that breaks showing file names.

* Enable WeakJACK only if JACK is available. * Try `pkg_check_modules` first when using WeakJACK, too.

Fixes a regression in 063b7c9.

* Bundle 64-bit version of JACK for 64-bit installer. * Change some CMake logic for NSIS

should return with empty buffer.

…ocked.

Since it may cause quality loss, we have decided to remove it and just use on-the-fly resampling while playing.

Also renames misleading `shouldLockMixer` to `syncWithMixer`.

PhysSong · 2019-03-17T06:08:39Z

You can find newest test binaries here: https://github.com/PhysSong/lmms/releases/tag/record

Reflexe · 2019-03-17T08:59:57Z

@PhysSong Great job with SampleBuffer! Do you think we need more refactoring on other parts of this PR?

Reflexe

I will fix these in the next days.

include/MemoryManager.h

Reflexe · 2019-03-17T09:12:41Z

include/SampleBuffer.h

@@ -168,19 +184,17 @@ class LMMS_EXPORT SampleBuffer : public QObject, public sharedObject

 	inline f_cnt_t frames() const
 	{
-		return m_frames;
+		dataReadLock();


I think I should use the RAII pattern here too.

include/SampleBuffer.h

Reflexe · 2019-03-17T09:13:50Z

include/SampleBuffer.h

+	 * @param begin	Beginning of an InputIterator.
+	 * @param end	End of an InputIterator.
+	 * @param syncWithMixer	Should we call requestChangeInModel?
+	 * @return


What does it returns? (success)

include/SampleBuffer.h

Reflexe · 2019-03-17T09:21:24Z

plugins/audio_file_processor/audio_file_processor.cpp

@@ -343,7 +343,12 @@ void audioFileProcessor::setAudioFile( const QString & _audio_file,

 void audioFileProcessor::reverseModelChanged( void )
 {
-	m_sampleBuffer.setReversed( m_reverseModel.value() );
+	if (m_reverseModel.value () != m_isCurrentlyReversed) {


it loadSettings calls this functions, m_isCurrentlyReversed won't be initialized (at least, not for the loaded buffer; it'll be initialized to m_reverseModel's current value) on line 269.

I still don't know how to solve that. Maybe just a isLoading attribute. :\

PhysSong · 2019-05-06T03:07:52Z

@Reflexe How is your work going on? Do you need some help?

Reflexe · 2019-05-31T04:57:01Z

Closed in favour of the rebased and refactored version at #4994

PhysSong added enhancement in progress labels Aug 9, 2018

PhysSong added this to the 1.3.0 milestone Aug 9, 2018

SecondFlight mentioned this pull request Sep 9, 2018

fix sampletrack playback (#4328) #4586

Merged

tresf mentioned this pull request Sep 19, 2018

Better Sample Track support #1471

Open

29 tasks

PhysSong mentioned this pull request Sep 19, 2018

Problems with the sample track #4598

Closed

PhysSong mentioned this pull request Oct 17, 2018

Recording -> SampleBuffer -> TripleOscillator: Support loading empty files and add samples/empty.wav #4536

Closed

Reflexe added 15 commits March 11, 2019 16:58

SampleTrack: Uncomment disabled recording-related code.

0b60e03

SampleTrack: Fix TCO not being played on the first tick (if it starts on

577631e

tick 0)

AudioJack: Basic implementation of capture (without AUDIO_PORT_SUPPORT)

78fa8e6

Mixer & PlayHandle: Support PlayHandle without audioPort and set

b9c42f6

audioPort as nullptr by default.

Mixer -> pushInputFrames: Add an option to automaticly normalize input

c827401

frames by the masterGain.

AudioPulseAudio: Switch playback sample type to float and add capture

425e33e

support.

Track -> SampleTrack: Do not save start time offset for empty

2da3701

SampleTCOs.

AudioJack: Allocate and deallocate m_tempInBufs.

b1b829f

SampleTrack: Make sure an empty TCO with isRecord would still be

989de31

"played" (recorded).

SampleTrack: Reset the start time offset when importing a new

3ea8e64

SampleBuffer. That solves problem with recording that caused samples to be moved and messed up. Thanks @-BaraMGB for helping.

SampleRecordHandle: Apply start offset to reocrded TCO.

8de8f50

Previously, begining record in any position would result the data being in the end of the TCO. @see #3947 (comment) Thanks to @-BaraMGB :)

Track, TrackView: Instead of trying every possible dynamic_cast in

ef953c4

`updateMenu`, use a virtual function overriden by every Track implemetation.

Editor -> Style: Reorder editor buttons.

f921fb2

SampleTrack -> RecordingChannel: Remove the default option, instead, all

3da70e8

options unchecked will be considered as global default. Suggested by @-tresf, Thanks!

lukas-w and others added 18 commits March 11, 2019 16:58

SampleBuffer::play: Fix freq factor calculation

20aa5bc

Fixes regression from f765773 (presumably a copy/paste mistake)

Remove bundled Jack headers, use system headers instead

e033891

CMake: Fix finding jack when cross-compiling with non-standard CMake

9ee6442

Thanks to @-PhysSong.

Fix PatMan patch loading

01bc0b5

Fixes a regression in 84a1f35.

Fix setting sample buffer name

40938ad

Fixes a regression in 7bc0056 that breaks showing file names.

Use CMake's file command to download JACK installer

48aef8b

MmAllocator: add missing constructors

94030a8

Improve JACK finding logic

a0e0bac

* Enable WeakJACK only if JACK is available. * Try `pkg_check_modules` first when using WeakJACK, too.

Don't try to resample empty data

815a185

Fix remaining file name reset issues

22037c9

Fix JACK installer download

e8271c8

Fixes a regression in 063b7c9.

Improve JACK installation on Windows

e5f61b1

* Bundle 64-bit version of JACK for 64-bit installer. * Change some CMake logic for NSIS

SampleBuffer: Don't treat an empty file as an error

64fc3c7

Bugfix -> SampleBuffer: To avoid arithmetic exception, userWaveSample

4cea3be

should return with empty buffer.

Bugfix -> SampleBuffer: Don't unlock the mixer when it has not been l…

4d3c902

…ocked.

SampleBuffer: Disable automatic up-sampling to the mixer's sample rate.

e3a736b

Since it may cause quality loss, we have decided to remove it and just use on-the-fly resampling while playing.

Fix TripleOscillator preset previewing due to nonexistent waveform files

2934ad5

SampleBuffer: use the RAII pattern when changing its data

df9a2f4

Also renames misleading `shouldLockMixer` to `syncWithMixer`.

PhysSong force-pushed the feature/recording branch from 2efd265 to df9a2f4 Compare March 11, 2019 08:02

Reflexe requested changes Mar 17, 2019

View reviewed changes

Gabrielxd195 mentioned this pull request May 12, 2019

Sample Track: Edit samples using AFP. #4971

Open

Reflexe mentioned this pull request May 25, 2019

Improvement: Audio Editor Model #4992

Open

PhysSong mentioned this pull request May 31, 2019

Recording after rebase to master #4994

Closed

11 tasks

Reflexe closed this May 31, 2019

rubiefawn mentioned this pull request Sep 5, 2019

Stale and unused branches #5172

Open

9 tasks

tresf deleted the feature/recording branch October 3, 2019 04:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sample track recording support #4531

Add sample track recording support #4531

PhysSong commented Aug 9, 2018 •

edited by Reflexe

Loading

Reflexe commented Aug 9, 2018 •

edited by PhysSong

Loading

PhysSong commented Aug 16, 2018

LmmsBot commented Sep 5, 2018 •

edited

Loading

PhysSong commented Sep 18, 2018

Reflexe commented Feb 21, 2019 •

edited

Loading

zonkmachine commented Feb 24, 2019

Reflexe commented Feb 24, 2019 •

edited

Loading

PhysSong commented Feb 24, 2019

PhysSong commented Mar 17, 2019

Reflexe commented Mar 17, 2019

Reflexe left a comment

Reflexe Mar 17, 2019 •

edited

Loading

Reflexe Mar 17, 2019

Reflexe Mar 17, 2019

Reflexe May 25, 2019

PhysSong commented May 6, 2019

Reflexe commented May 31, 2019

Add sample track recording support #4531

Add sample track recording support #4531

Conversation

PhysSong commented Aug 9, 2018 • edited by Reflexe Loading

Bugs

Enhancements

Reflexe commented Aug 9, 2018 • edited by PhysSong Loading

PhysSong commented Aug 16, 2018

LmmsBot commented Sep 5, 2018 • edited Loading

Downloads for this pull request

PhysSong commented Sep 18, 2018

Reflexe commented Feb 21, 2019 • edited Loading

zonkmachine commented Feb 24, 2019

Reflexe commented Feb 24, 2019 • edited Loading

PhysSong commented Feb 24, 2019

PhysSong commented Mar 17, 2019

Reflexe commented Mar 17, 2019

Reflexe left a comment

Choose a reason for hiding this comment

Reflexe Mar 17, 2019 • edited Loading

Choose a reason for hiding this comment

Reflexe Mar 17, 2019

Choose a reason for hiding this comment

Reflexe Mar 17, 2019

Choose a reason for hiding this comment

Reflexe May 25, 2019

Choose a reason for hiding this comment

PhysSong commented May 6, 2019

Reflexe commented May 31, 2019

PhysSong commented Aug 9, 2018 •

edited by Reflexe

Loading

Reflexe commented Aug 9, 2018 •

edited by PhysSong

Loading

LmmsBot commented Sep 5, 2018 •

edited

Loading

Reflexe commented Feb 21, 2019 •

edited

Loading

Reflexe commented Feb 24, 2019 •

edited

Loading

Reflexe Mar 17, 2019 •

edited

Loading