Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck keys when dragging on piano view #5127

Merged
merged 2 commits into from Sep 8, 2019
Merged

Conversation

@DomClark
Copy link
Member

@DomClark DomClark commented Aug 16, 2019

Fixes #5028.

It is possible for NotePlayHandle::noteOff to be called before NotePlayHandle::play is called for the first time, which results in a note-on message being sent without a subsequent note-off message. This PR checks whether the note has already been released before sending the note-on message.

src/core/NotePlayHandle.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Shmuel H. <shmuelhazan0@gmail.com>
@PhysSong PhysSong added this to the 1.2.1 milestone Aug 20, 2019
@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Sep 8, 2019

Tested, works!

Merge?

@zonkmachine zonkmachine merged commit 2e84cd3 into LMMS:stable-1.2 Sep 8, 2019
2 checks passed
@DomClark DomClark deleted the fix-5028 branch Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants