Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with Carla 2.4.3 #6403

Merged
merged 1 commit into from
May 24, 2022

Conversation

PhysSong
Copy link
Member

@PhysSong PhysSong commented May 9, 2022

Replaces #6397.
Include CarlaDefines.h before using CARLA_VERSION_HEX to prevent hitting wrong preprocessor path.

Note that if we bump up Carla version requirement to 1.9.11=2.0-RC1, the #else part is not required.

@PhysSong PhysSong mentioned this pull request May 9, 2022
@LmmsBot
Copy link

LmmsBot commented May 9, 2022

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/abef3c84-9c86-42ee-a5d9-c4d918121198/artifacts/0/lmms-1.2.3-939+g9c49a7747-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1385?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/6120b7b7-b30a-4f12-8103-39220c9f46f6/artifacts/0/lmms-1.2.3-939+g9c49a7747-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1382?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/035c41b0-f206-477b-bb45-2a2b5e8b46dd/artifacts/0/lmms-1.2.3-939+g9c49a7747-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1381?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ss9cv2q22x50es7l/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43477914"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/i7mnmi9lqkx7lh11/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43477914"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/9154a2d7-4259-41c5-975c-15270cc532e8/artifacts/0/lmms-1.2.3-939+g9c49a7747-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1384?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "9c49a7747c38ac0a3dd1c21d30019a830155d500"}

@PhysSong PhysSong merged commit 3518d30 into LMMS:master May 24, 2022
@PhysSong PhysSong deleted the fix-carla-compilation branch May 24, 2022 00:57
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants