lmms: Add support for Carla

[Rampoina]

Add Carla as an optional dependency and the needed patch.
This adds the Carla rack and Carla instrument LMMS plugins.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[orivej]

Here is the upstream issue: LMMS/lmms#6395
And here is the corresponding patch: LMMS/lmms#6403
Could you apply it with fetchfatch? (https://github.com/LMMS/lmms/commit/3518d307f47c79db06bd0e9430f39b91488673dc.patch)
Fixes with sed are difficult to maintain, it is hard to know when they become obsolete.

[Rampoina]

@orivej thanks for the suggestion, I'll work on that this friday

[orivej]

Thanks! Your help is welcome!

[Rampoina]

Here is the upstream issue: LMMS/lmms#6395 And here is the corresponding patch: LMMS/lmms#6403 Could you apply it with fetchfatch? (https://github.com/LMMS/lmms/commit/3518d307f47c79db06bd0e9430f39b91488673dc.patch) Fixes with sed are difficult to maintain, it is hard to know when they become obsolete.

@orivej It looks like the files plugins/carlabase/carla.h were renamed to camelcase at some point so the patch doesn't apply.

Even if we change the names it still doesn't apply because of this line (and others) which comes from this feature

This patch from Arch Linux would apply or we could also include it ourselves.
How do you suggest to proceed?

[orivej]

Good idea! However, the link https://raw.githubusercontent.com/archlinux/svntogit-community/packages/lmms/trunk/lmms-carla-export.patch will expire as soon as ArchLinux deletes that patch (probably when they update lmms). To keep the link working we refer to patches on github by their tags or hashes rather than by their branch names (in this case the branch name is packages/lmms). To obtain a stable link you can open https://github.com/archlinux/svntogit-community/blob/packages/lmms/trunk/lmms-carla-export.patch , press y on the keyboard (or click … near "Go to file", choose "Copy permalink", and visit the copied link), and then click "Raw" and copy the link from the browser url bar. In this case the result is https://raw.githubusercontent.com/archlinux/svntogit-community/cf64acc45e3264c6923885867e2dbf8b7586a36b/trunk/lmms-carla-export.patch