Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

replace alias name with wallet name in the onboarding process #1025

Closed
lieteau2 opened this issue Dec 4, 2018 · 2 comments
Closed

replace alias name with wallet name in the onboarding process #1025

lieteau2 opened this issue Dec 4, 2018 · 2 comments
Assignees
Labels
branch: next type: enhancement New feature or request
Milestone

Comments

@lieteau2
Copy link

lieteau2 commented Dec 4, 2018

Detailed Description

changing alias name with wallet name during onboarding process for practical/ user improvements

@lieteau2 lieteau2 changed the title replace alias with name in the onboarding process replace alias name with wallet name in the onboarding process Dec 4, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix LN-Zap#1025
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix LN-Zap#1025
@mrfelton
Copy link
Member

mrfelton commented Dec 4, 2018

Implemented in #1026 @lieteau2

@mrfelton mrfelton self-assigned this Dec 4, 2018
@mrfelton mrfelton added this to the v0.3.0-beta milestone Dec 4, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix LN-Zap#1025
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix LN-Zap#1025
@mrfelton
Copy link
Member

mrfelton commented Dec 5, 2018

Fixed via #1026

@mrfelton mrfelton closed this as completed Dec 5, 2018
mrfelton added a commit that referenced this issue Dec 12, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix #1025
mrfelton added a commit that referenced this issue Dec 12, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix #1025
mrfelton added a commit that referenced this issue Dec 15, 2018
Allow setting the wallet name in the onboarding process rather than
the wallet alias. This makes more sense since local wallets operate
in private mode and therefore do not broadcast their address or alias
to the network.

Fix #1025
@mrfelton mrfelton added type: enhancement New feature or request and removed type: enhancement labels Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
branch: next type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants