This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
feat(onboarding): allow setting wallet name #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
feat/onboarding-wallet-name
branch
from
6b2d7e3
to
54be043
Compare
Allow setting the wallet name in the onboarding process rather than the wallet alias. This makes more sense since local wallets operate in private mode and therefore do not broadcast their address or alias to the network. Fix LN-Zap#1025
mrfelton
force-pushed
the
feat/onboarding-wallet-name
branch
from
54be043
to
2bbb16d
Compare
JimmyMow
approved these changes
Dec 4, 2018
mrfelton
added
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow setting the wallet name in the onboarding process rather than the wallet alias.
Motivation and Context:
This makes more sense since local wallets operate in private mode and therefore do not broadcast their address or alias to the network.
Fix #1025
How Has This Been Tested?
Manually + Storybook
Screenshots (if appropriate):
Types of changes:
Enhancement
Checklist: