Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Incorrect $ => BTC conversion #1953

Closed
JesseLawler opened this issue Apr 4, 2019 · 1 comment · Fixed by #1967
Closed

Incorrect $ => BTC conversion #1953

JesseLawler opened this issue Apr 4, 2019 · 1 comment · Fixed by #1967
Assignees
@mrfelton
Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Milestone
v0.4.1-beta

Comments

@JesseLawler
Copy link

JesseLawler commented Apr 4, 2019 •
edited by mrfelton
Loading

I tried to send $199, and Zap estimated this value in satoshis (incorrectly) at 4,835,739.

Description

Today's market price at Bitcoin/USD has not been anywhere near what this bad conversion implies.

Expected Behavior

The amount in satoshis should have been correct.

Actual Behavior

It wasn't. :D

Possible Fix

Review the code doing a real-time look-up of BTC/USD prices.

Context

Sending a correct payment by entering a USD value and not manually double-checking that the BTC value was an equivalent.

Your Environment

  • Zap version: 0.4.0-beta
  • Operating System and version: Mac OS (newest), Zap Desktop

Screen Shot 2019-04-04 at 9 51 10 AM
@welcome
Copy link

welcome bot commented Apr 4, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mrfelton mrfelton added scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working labels Apr 5, 2019
@mrfelton mrfelton added this to the v0.4.1-beta milestone Apr 5, 2019
@mrfelton mrfelton self-assigned this Apr 6, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 6, 2019
@mrfelton
fix(wallet): refetch fiat tickers when forms open
82c00bd 
Refetch fiat ticker data every time one of our payment forms are open
in order to help ensure that conversion rates are up to date. Covers
the Pay, Request and CreateChannel forms.

Fix LN-Zap#1953
@mrfelton mrfelton mentioned this issue Apr 6, 2019
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.4.1-beta
Development

Successfully merging a pull request may close this issue.

fix(wallet): refetch fiat tickers when forms open mrfelton/zap-desktop
2 participants
@mrfelton @JesseLawler