Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect $ => BTC conversion #1953

Closed
EvilGeniusTechnologies opened this Issue Apr 4, 2019 · 1 comment

Comments

2 participants
@EvilGeniusTechnologies
Copy link

EvilGeniusTechnologies commented Apr 4, 2019

I tried to send $199, and Zap estimated this value in satoshis (incorrectly) at 4,835,739.

Description

Today's market price at Bitcoin/USD has not been anywhere near what this bad conversion implies.

Expected Behavior

The amount in satoshis should have been correct.

Actual Behavior

It wasn't. :D

Possible Fix

Review the code doing a real-time look-up of BTC/USD prices.

Context

Sending a correct payment by entering a USD value and not manually double-checking that the BTC value was an equivalent.

Your Environment

  • Zap version: 0.4.0-beta
  • Operating System and version: Mac OS (newest), Zap Desktop

Screen Shot 2019-04-04 at 9 51 10 AM

@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 4, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mrfelton mrfelton added this to the v0.4.1-beta milestone Apr 5, 2019

@mrfelton mrfelton self-assigned this Apr 6, 2019

mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Apr 6, 2019

fix(wallet): refetch fiat tickers when forms open
Refetch fiat ticker data every time one of our payment forms are open
in order to help ensure that conversion rates are up to date. Covers
the Pay, Request and CreateChannel forms.

Fix LN-Zap#1953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.