Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

feat(litecoin): add litecoin support #1081

Merged
merged 7 commits into from
Dec 14, 2018
Merged

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Dec 13, 2018

Description:

Misc fixes and adjustments to get things working with litecoin nodes.

  • ensure wallet info saves correctly
  • support litecoin currency conversions
  • remove bitcoin specific language
  • patch bolt11 to support litecoin
  • link to chain specific block explorers

Motivation and Context:

Support litecoin

How Has This Been Tested?

Manually - connect to a remote litecoin node and use the wallet

Types of changes:

Adjustments

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: enhancement New feature or request label Dec 13, 2018
@mrfelton mrfelton added this to the v0.3.0-beta milestone Dec 13, 2018
@mrfelton mrfelton self-assigned this Dec 13, 2018
@mrfelton mrfelton force-pushed the fix/litecoin branch 3 times, most recently from a0987b6 to c1c276d Compare December 13, 2018 01:16
@coblee
Copy link

coblee commented Dec 13, 2018

Awesome! @losh11 will be able to review and test this soon.

@losh11
Copy link
Contributor

losh11 commented Dec 14, 2018

tACK - however we'd prefer if the photons denomination is replaced by lites (ł). In Litecoin Core and various other wallets, by default we've also been using lites for a while now, and it would be preferred if Zap had consistency with these other wallets.

1 Litecoin (Ł) = 1,000 lites (ł)
Code otherwise looks perfect! 👍

@JimmyMow
Copy link
Member

Tested ACK 3e826f2

@losh11 would you mind creating an issue for the lites request? I feel it is a bit out of scope for this PR as we first want some stable LTC functionality in place. Will follow up with a separate PR for the lites request

@JimmyMow JimmyMow merged commit 3a55178 into LN-Zap:next Dec 14, 2018
@mrfelton mrfelton deleted the fix/litecoin branch December 14, 2018 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
branch: next type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants