Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

refactor: fix appRootPath to run in main or preload process #2201

Merged
merged 1 commit into from
May 16, 2019

Conversation

mrfelton
Copy link
Member

Description:

fix appRootPath to run in main or preload process

Motivation and Context:

Fixes an issue that prevents that app from starting up in production mode yarn package

How Has This Been Tested?

  • yarn dev
  • yarn start
  • yarn package

Types of changes:

Fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: bug 🐛 Something isn't working label May 14, 2019
@mrfelton mrfelton added this to the v0.5.0-beta milestone May 14, 2019
@mrfelton mrfelton requested a review from korhaliv May 14, 2019 19:08
@mrfelton mrfelton self-assigned this May 14, 2019
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 0e66fa6

@mrfelton mrfelton merged commit 3f9ba3d into LN-Zap:next May 16, 2019
@mrfelton mrfelton deleted the fix/app-root-path branch May 16, 2019 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants