Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(onboarding): improved connection error messages #2206

Merged
merged 1 commit into from May 16, 2019

Conversation

mrfelton
Copy link
Member

Description:

Improved connection error messages.

This PR ports over some error handling from master that got lost in the gRPC refactor and adds some additional detail to the Failed to connect before the deadline message to help users diagnose the issue.

Error messages are not i18n aware as is the case for many errors message throughout the app - adding i18n support to the error messages can be handled separately.

Motivation and Context:

Fix #1564

How Has This Been Tested?

Try connecting with an invalid cert.

Screenshots (if appropriate):

image

Types of changes:

Enhancement

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: enhancement scope: onboarding issues relating to the onboarding process labels May 15, 2019
@mrfelton mrfelton added this to the v0.5.0-beta milestone May 15, 2019
@mrfelton mrfelton requested a review from korhaliv May 15, 2019 14:31
@mrfelton mrfelton self-assigned this May 15, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 20.115% when pulling 253ae63 on mrfelton:fix/1564-better-cert-errors into ed8bda5 on LN-Zap:next.

Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 253ae63

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: onboarding issues relating to the onboarding process type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants