This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix(onboarding): improved connection error messages #2206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improved connection error messages.
This PR ports over some error handling from master that got lost in the gRPC refactor and adds some additional detail to the
Failed to connect before the deadline
message to help users diagnose the issue.Error messages are not i18n aware as is the case for many errors message throughout the app - adding i18n support to the error messages can be handled separately.
Motivation and Context:
Fix #1564
How Has This Been Tested?
Try connecting with an invalid cert.
Screenshots (if appropriate):
Types of changes:
Enhancement
Checklist: