-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with constant socket2 non-semver changes breaking android builds #159
Comments
ContextAs reported in #156, after removing the socket2 pinned version, Android build gets broken. At the moment when the problem arose, it was decided to leave it there for the time being because otherwise the new projects would not have been able to plug in LNP/BP core lib. See the corresponding comment here #156 (comment) Logs
Action pointThis issue is the reminder to fix the mentioned bug discovered in #156 at some point. Everyone who wants to get involved/fix it can feel free to take the task. |
This was already fixed by me in the last RC2 before this issue was opened, which I wrote about to IRC and the PR itself: #158 |
Reopening since the thing got broken once again: today they have yanked the version we were using before! See https://crates.io/crates/socket2 NB: This is completely unrelated issue to the previous one |
More background: rust-lang/socket2#139 |
Solved by 3999313 |
as reported in #156, the android build is now broken (example):
The text was updated successfully, but these errors were encountered: