Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with constant socket2 non-semver changes breaking android builds #159

Closed
nicbus opened this issue Dec 3, 2020 · 5 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nicbus
Copy link
Member

nicbus commented Dec 3, 2020

as reported in #156, the android build is now broken (example):

error: /home/runner/work/rust-lnpbp/rust-lnpbp/target/debug/deps/liblnpbp_derive-5ea54e98b0ad9738.so: undefined symbol: __errno
  --> src/lib.rs:65:1
   |
65 | extern crate lnpbp_derive;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: could not compile `lnpbp`
@UkolovaOlga UkolovaOlga added the bug Something isn't working label Dec 3, 2020
@UkolovaOlga UkolovaOlga changed the title removing socket2 pinned version breaks android build Removing socket2 pinned version breaks android build Dec 4, 2020
@UkolovaOlga UkolovaOlga added the good first issue Good for newcomers label Dec 4, 2020
@UkolovaOlga UkolovaOlga added this to To do in Software stack & toolchain via automation Dec 4, 2020
@UkolovaOlga
Copy link
Member

UkolovaOlga commented Dec 4, 2020

Context

As reported in #156, after removing the socket2 pinned version, Android build gets broken. At the moment when the problem arose, it was decided to leave it there for the time being because otherwise the new projects would not have been able to plug in LNP/BP core lib. See the corresponding comment here #156 (comment)

Logs

error: /home/runner/work/rust-lnpbp/rust-lnpbp/target/debug/deps/liblnpbp_derive-5ea54e98b0ad9738.so: undefined symbol: __errno
  --> src/lib.rs:65:1
   |
65 | extern crate lnpbp_derive;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: could not compile `lnpbp

Action point

This issue is the reminder to fix the mentioned bug discovered in #156 at some point. Everyone who wants to get involved/fix it can feel free to take the task.

@dr-orlovsky
Copy link
Member

dr-orlovsky commented Dec 5, 2020

This was already fixed by me in the last RC2 before this issue was opened, which I wrote about to IRC and the PR itself: #158

Software stack & toolchain automation moved this from To do to Done Dec 5, 2020
@dr-orlovsky
Copy link
Member

Reopening since the thing got broken once again: today they have yanked the version we were using before! See https://crates.io/crates/socket2

NB: This is completely unrelated issue to the previous one

@dr-orlovsky dr-orlovsky reopened this Dec 6, 2020
Software stack & toolchain automation moved this from Done to In progress Dec 6, 2020
@dr-orlovsky dr-orlovsky changed the title Removing socket2 pinned version breaks android build Problems with constant socket2 non-semver changes breaking android builds Dec 6, 2020
@dr-orlovsky
Copy link
Member

More background: rust-lang/socket2#139

@dr-orlovsky
Copy link
Member

Solved by 3999313

Software stack & toolchain automation moved this from In progress to Done Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

3 participants