Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tokio dependency breaking change #156

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

dr-orlovsky
Copy link
Member

One of tokio dependencies has updated it's dependencies in minor version and led to Cargo.lock conflict with a patch required for android version. I have temporarily disabled it since it's impossible to update upstream crates (adding any dependency there requires update to the Cargo.lock, which fails due to this problem).

@dr-orlovsky dr-orlovsky added the ci Continious integration label Dec 2, 2020
@dr-orlovsky dr-orlovsky added this to In progress in Client-side-validation via automation Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #156 (04a53c6) into master (064b2f5) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #156     +/-   ##
========================================
- Coverage    57.8%   57.8%   -0.1%     
========================================
  Files          78      78             
  Lines       12219   11872    -347     
========================================
- Hits         7068    6857    -211     
+ Misses       5151    5015    -136     
Impacted Files Coverage Δ
src/lib.rs 25.0% <0.0%> (-53.9%) ⬇️
src/rgb/contract/assignments.rs 80.8% <0.0%> (+0.1%) ⬆️
derive/src/lib.rs 83.2% <0.0%> (+18.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064b2f5...04a53c6. Read the comment docs.

@dr-orlovsky
Copy link
Member Author

This think broke everything: miow v0.3.6. They have yanked all previous versions and introduced breaking changes with new one: https://crates.io/crates/miow/versions

@dr-orlovsky
Copy link
Member Author

Removing socket2 pinned version breaks android build, but anyway newly created projects will not be able to use LNP/BP Core library w/o this at all, so better to have android build broken for now (and fix it later) than being unable to plug in LNP/BP core lib into new projects at all

@dr-orlovsky dr-orlovsky merged commit 4a9217e into master Dec 2, 2020
Client-side-validation automation moved this from In progress to Done Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continious integration
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant