Update project to use Typescript #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denwilliams
commented
Jul 14, 2022
| Add multi-line text here.`; | ||
| } | ||
| } | ||
| const ErrorA = createErrorType({ |
There was a problem hiding this comment.
We don't support the extends approach any more
denwilliams
commented
Jul 14, 2022
denwilliams
force-pushed
the
feature/typescript
branch
2 times, most recently
from
9450d7a
to
2d7c787
Compare
denwilliams
force-pushed
the
feature/typescript
branch
from
2d7c787
to
1bacf50
Compare
smithamax
reviewed
Jul 18, 2022
package.json
Outdated
| @@ -17,10 +19,14 @@ | |||
| }, | |||
| "homepage": "https://github.com/LOKE/errors#readme", | |||
| "dependencies": { | |||
| "logfmt": "^1.3.2", | |||
There was a problem hiding this comment.
not super keen on adding this dep for such a low level lib
smithamax
approved these changes
Jul 18, 2022
denwilliams
force-pushed
the
feature/typescript
branch
from
942dfed
to
f86d614
Compare
smithamax
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the project to Typescript.
Also updates dependencies which should resolve Github security notifications.
Supports type checking for required meta, which should help in enforcing the required params for constructing errors.