Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer rtcm_msgs over mavros_msgs #34

Closed
wants to merge 2 commits into from
Closed

Prefer rtcm_msgs over mavros_msgs #34

wants to merge 2 commits into from

Conversation

LuckierDodge
Copy link

rtcm_msgs is a smaller dependency with support for both ROS and ROS 2 now, and preferred by some downstream dependencies like ublox.

robbiefish
robbiefish approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@robbiefish robbiefish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but would like to update our device driver to use those messages first. Once I have done that, I will merge this in

@gsokoll gsokoll mentioned this pull request Apr 4, 2023
Merged
@robbiefish
Copy link
Contributor

Closing in favor of #37 and #38

@robbiefish robbiefish closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbiefish robbiefish robbiefish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LuckierDodge @robbiefish