Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add checks for (r/m/c)<=0 in all profile functions #393

Merged
merged 4 commits into from
Jun 11, 2021
Merged

add checks for (r/m/c)<=0 in all profile functions #393

merged 4 commits into from
Jun 11, 2021

Conversation

m-aguena
Copy link
Collaborator

No description provided.

@m-aguena m-aguena linked an issue Apr 30, 2021 that may be closed by this pull request
Silent crash with Cluster Toolkit #374
Closed
2 tasks
@coveralls
Copy link

coveralls commented Apr 30, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6d8106c on issue/374/ct_silent_crash into 7011d44 on master.

@m-aguena m-aguena changed the title add checks for r<=0 in all profile functions add checks for (radus or mass or concentration)<=0 in all profile functions Apr 30, 2021
@m-aguena m-aguena changed the title add checks for (radus or mass or concentration)<=0 in all profile functions add checks for (r/m/c)<=0 in all profile functions Apr 30, 2021
@m-aguena m-aguena requested review from vitenti and combet April 30, 2021 16:24
combet
combet approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@combet combet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m-aguena, all looks good.

@combet combet removed a link to an issue May 7, 2021
Silent crash with Cluster Toolkit #374
Closed
2 tasks
@combet combet linked an issue May 7, 2021 that may be closed by this pull request
Silent crash with Cluster Toolkit #374
Closed
2 tasks
@combet combet merged commit 62d3868 into master Jun 11, 2021
@combet combet deleted the issue/374/ct_silent_crash branch February 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@combet combet combet approved these changes

@vitenti vitenti Awaiting requested review from vitenti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silent crash with Cluster Toolkit
3 participants
@m-aguena @coveralls @combet