Issues/165 #166
Issues/165 #166
Conversation
numpy.histogram2d returns vertical, than horizontal (which is the opposite of the naively expected x, y)
Add astroMl link.
Standarize colormap and make configurable
| } | ||
| }, | ||
| "source": [ | ||
| "# Looking at merged tract-patch catalogs in Run 1.1 leading up to DC2\n", |
There was a problem hiding this comment.
From the title alone I'm not entirely sure what this notebook is intended to convey. A brief description at the beginning that explains what will be demonstrated would be useful. This might include instructions on any file paths the user needs to set, or simply that the notebook is intended to be run on NERSC.
| "plt.xlabel('g-r')\n", | ||
| "plt.ylabel('r-i')\n", | ||
| "\n", | ||
| "plot_stellar_locus('gmr', 'rmi')" |
There was a problem hiding this comment.
FileNotFoundError: File b'Davenport_2014_MNRAS_440_3430_table1.txt' does not exist
There was a problem hiding this comment.
From what directory are you running the notebook?
There was a problem hiding this comment.
Just my user directory. I did a little directory tree exploration for the file but didn't see it.
There was a problem hiding this comment.
It's in the same directory as the notebook. Did you use the NERSC Jupyter-dev interface to run this?
There was a problem hiding this comment.
When ssh-ing into cori and cloning the DC2_Repo repo this error does not occur. Previously had an issue with my ssh access and was using the Jupyter upload interface. I simply forgot to upload this file.
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "def simple_stellar_locus_gmr_rmi(color='red', linestyle='--', linewidth=2.5):\n", |
There was a problem hiding this comment.
Docstring for simple_stellar_locus_gmr_rmi would be useful for clarity. I'm specifically unclear on where the numbers 1.4, 0.5, 1.5, -0.5, ... come from.
| "outputs": [], | ||
| "source": [ | ||
| "z = galaxies\n", | ||
| "plt.scatter(z['g_mag'] - z['r_mag'], z['g_mag'], marker='.')\n", |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Clean this up a bit to only include stars with SNR > 3 in g and r" |
There was a problem hiding this comment.
You say you are going to implement a cut for SNR > 3, but then impliment 3 different cutoffs. This left me with some minor but unnecessary confusion. Explain first that you are going to use different SNR to create 3 different catagories: good snr, bright stars, and galaxies.
| "* The catalogs supporting DC2 are in:\n", | ||
| "https://github.com/LSSTDESC/gcr-catalogs\n", | ||
| "\n", | ||
| "See 'DC2_Static_Coadd_Catalog_reader.ipynb' notebook by Yao-Yuan Mao\n", |
There was a problem hiding this comment.
Link to DC2_Static_Coadd_Catalog_reader.ipynb for easy navigation.
There was a problem hiding this comment.
The next line is that link. Does it show up for you?
There was a problem hiding this comment.
Ah yes, for some reason I had thought that was something else. Not the notebook's fault, just a personal mental skip.
There was a problem hiding this comment.
The notebook looks good to me.
On a side note, we now start to have more example notebooks that use different methods to access DC2 products. While this is totally fine, sometimes it is difficult to people who are not following to navigate and to find the best option for them. We should document this somewhere to make things organized.
|
@yymao Agreed. I hope that we can stop at four. 1) GCR 2) DB 3) Merged catalog 4) Butler-based |
Example notebook for loading a merged tract+patch from an HDF5 file and checking the stellar color-color locus.