Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage to make source maps from binned shear catalog instead of doing calibration internally #320

Merged
merged 17 commits into from
Dec 11, 2023

Conversation

joezuntz
Copy link
Collaborator

This PR depends on #317 which contains almost all its contents, so should be looked at only after that is merged.

It replaces the source mapper with a dask-based version which is much simpler and doesn't use any complicated classes.

@joezuntz joezuntz marked this pull request as ready for review August 25, 2023 12:22
Copy link
Contributor

@empEvil empEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I am no expert on DASK so maybe get someone else to help if the DASK calls are correct? or can you link me to some details?

Copy link
Contributor

@empEvil empEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Joe knows how to write DASK, this looks good

@joezuntz joezuntz merged commit 1707251 into master Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants