Simplify tomography files and mappers #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@empEvil did you have a chance to look at this? |
|
No not yet, I happened to get sick :( |
|
Get well soon! |
empEvil
reviewed
Aug 18, 2023
|
Thanks for the review! As far as I can tell I've dealt with all the places where there's a name confusion. I'm sure we'll hit something else eventually! |
|
Could you approve if you're happy? |
empEvil
approved these changes
Aug 24, 2023
|
Thanks!!! |
combet
added a commit
that referenced
this pull request
Sep 7, 2023
…in master from PR #317 (simplify tomography files and mappers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tomography files unnecessarily distinguish "source_bin" and "lens_bin" columns in files, making it harder to use them generically.
This changes this so that all tomo files have a set of common columns. At the same time, I removed the old TXMainMaps class, which assumed identical lens and source catalogs, because it would not work straightforwardly with this change (because both lens and source bins are now called "bin"), and rewrote the Mapper class as ShearMapper and LensMapper (it was never being used to do both at once outside TXMainMaps).
As a side point this finally does the source number count maps.
This was making the code more complicated than it needed to be when writing code to use QP and do truth photo-z summations.