Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hsc y3 #351

Merged
merged 16 commits into from
May 29, 2024
Merged

Hsc y3 #351

merged 16 commits into from
May 29, 2024

Conversation

yomori
Copy link
Contributor

@yomori yomori commented May 10, 2024

This PR adds the hsc-y3 cosmic-shear pipeline

jmjefferson
jmjefferson reviewed May 10, 2024
View reviewed changes
txpipe/calibrate.py Outdated Show resolved Hide resolved
elvinpoole
elvinpoole requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@elvinpoole elvinpoole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. There are a couple conflicts in txpipe/calibrate.py
and txpipe/psf_diagnostics.py that look like they are coming from the lensfit additions, so we will need to merge master into this branch and resolve those before merging

examples/hscy3/hsc_pipeline.yaml Outdated Show resolved Hide resolved
yomori
yomori commented May 20, 2024
View reviewed changes
Copy link
Contributor Author

@yomori yomori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged back in master and updated

@yomori yomori requested a review from elvinpoole May 20, 2024 16:45
elvinpoole
elvinpoole approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@elvinpoole elvinpoole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I approved, but also added one comment to check in case useful. Feel free to merge

txpipe/twopoint.py Show resolved Hide resolved
@yomori yomori merged commit 7841ddc into master May 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjefferson jmjefferson jmjefferson left review comments

@elvinpoole elvinpoole elvinpoole approved these changes

@chihway chihway Awaiting requested review from chihway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yomori @elvinpoole @jmjefferson