-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to filter catalog before running readiness test #201
Conversation
evevkovacs
commented
May 1, 2020
•
edited
Loading
edited
#202 should fix the linter issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If it passes the new linter checks this can be merged.
@yymao I wasn't sure how to trigger another run of the checks, so I made a trivial change in the code and pushed to the branch. As you can see the checks failed. But I failed to update from master, so let me try again. Hmm, git claims I am up to date, so sorry but I need help to get the updated checks to run on this branch. |
I just merged #202 and update this branch. The checks are being rerun now. |
@yymao Ah, you hadn't pushed to master yet. OK, so now everything passed. Could you please re-approve, and then I will merge? Thanks, and sorry for my confusion. BTW, for future reference, how do I trigger a rerun of the checks without changing the code. |
@evevkovacs I think if you go to the "Actions" tab, and then select the failing run, and then click "build (3.7)" from the left sidebar, and then you should see a "Re-run all jobs" button on the very right end. |
Thanks! |