Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter catalog before running readiness test #201

Merged
merged 3 commits into from
May 4, 2020

Conversation

evevkovacs
Copy link
Contributor

@evevkovacs evevkovacs commented May 1, 2020

If you are submitting a PR for a validation test (either adding a new one or updating an existing one), please post a link to the DESCQA web interface for the test you are submitting.
This addition allows a filter to be applied to the catalog data before running the readiness tests. This was useful for testing the new baseDC2_5000 against the old catalog. baseDC2_5000 has a stellar-mass cut applied, which reduces the number of synthetic galaxies. I wanted to apply the same cut to the old baseDC2 catalog to do a comparison. The cosmic variance of the redshift distribution was of particular interest. Here's an example run for healpixel 9556

@evevkovacs evevkovacs requested a review from yymao May 1, 2020 23:34
@yymao yymao closed this May 4, 2020
@yymao yymao reopened this May 4, 2020
@yymao
Copy link
Member

yymao commented May 4, 2020

#202 should fix the linter issue.

yymao
yymao previously approved these changes May 4, 2020
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it passes the new linter checks this can be merged.

@evevkovacs
Copy link
Contributor Author

evevkovacs commented May 4, 2020

@yymao I wasn't sure how to trigger another run of the checks, so I made a trivial change in the code and pushed to the branch. As you can see the checks failed. But I failed to update from master, so let me try again. Hmm, git claims I am up to date, so sorry but I need help to get the updated checks to run on this branch.

@yymao
Copy link
Member

yymao commented May 4, 2020

I just merged #202 and update this branch. The checks are being rerun now.

@evevkovacs
Copy link
Contributor Author

@yymao Ah, you hadn't pushed to master yet. OK, so now everything passed. Could you please re-approve, and then I will merge? Thanks, and sorry for my confusion. BTW, for future reference, how do I trigger a rerun of the checks without changing the code.

@evevkovacs evevkovacs merged commit e9634cf into master May 4, 2020
@yymao
Copy link
Member

yymao commented May 4, 2020

@evevkovacs I think if you go to the "Actions" tab, and then select the failing run, and then click "build (3.7)" from the left sidebar, and then you should see a "Re-run all jobs" button on the very right end.

image

@evevkovacs
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants