Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter arguments in CI #202

Merged
merged 1 commit into from
May 4, 2020
Merged

Conversation

yymao
Copy link
Member

@yymao yymao commented May 4, 2020

This PR updates the linter arguments in the CI test to avoid CI test failures due to unnecessary linter complaints.

Copy link
Contributor

@evevkovacs evevkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with flake8 or pylint but can make an informed guess on what directives mean; explicit list of directories to check with flake8 looks correct; list of enabled conditions for pylint to enforce look reasonable. Don't understand the addition "actions/checkout@v2", since AFAIK, these checks were already being run for v2, but I must not be understanding the syntax. Otherwise LGTM

@yymao
Copy link
Member Author

yymao commented May 4, 2020

Thanks, @evevkovacs.

(v2 there is refering to the version of the "checkout" action, not DESCQA.)

@yymao yymao merged commit 9e39970 into master May 4, 2020
@yymao yymao deleted the u/yymao/update-linter-arguments branch May 4, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants