Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes and options for cosmetic changes to plots used for ma… #220

Merged
merged 10 commits into from
Mar 31, 2021

Conversation

evevkovacs
Copy link
Contributor

…king publication quality versions; config files for making figures for the validation paper.

There are many recent runs of the various tests. Here are some examples:
wprp_color
wprp_mag
color-z
galaxy-bias
size-bulge-disk
size-lum
position-angle

…king publication quality versions; config files for making figures for the validation paper.
@evevkovacs evevkovacs requested a review from yymao March 29, 2021 20:22
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evevkovacs --- please remove some remaining spaces in blank links.

There are several re.split added (and hence the need to import re); however, in those cases, the string method .partition can do the job. I'll leave this to you whether you want to change it, but in the future you may want to use .partition instead.

descqa/CorrelationsTwoPoint.py Outdated Show resolved Hide resolved
descqa/CorrelationsTwoPoint.py Outdated Show resolved Hide resolved
descqa/CorrelationsTwoPoint.py Outdated Show resolved Hide resolved
descqa/BiasVersusRedshift.py Outdated Show resolved Hide resolved
evevkovacs and others added 7 commits March 30, 2021 09:57
Co-authored-by: Yao-Yuan Mao <yymao.astro@gmail.com>
Co-authored-by: Yao-Yuan Mao <yymao.astro@gmail.com>
Co-authored-by: Yao-Yuan Mao <yymao.astro@gmail.com>
Co-authored-by: Yao-Yuan Mao <yymao.astro@gmail.com>
@evevkovacs
Copy link
Contributor Author

@yymao Changes made as requested; added more minor cosmetic adjustments for SMF tests and added some more config files for figures.

Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evevkovacs

@evevkovacs evevkovacs merged commit cecf7a0 into master Mar 31, 2021
@evevkovacs evevkovacs deleted the wprp_paper branch March 31, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants