Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added state control for updatable objects. #184

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Oct 3, 2022

Added testing and fixed pylint issues (old and new) on tests (including a pylintrc for tests and its inclusion on GHA).

…lint issues (old and new) on tests (including a pylintrc for tests and its inclusion on GHA).
@vitenti vitenti linked an issue Oct 3, 2022 that may be closed by this pull request
firecrown/parameters.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@marcpaterno marcpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be two (minor) comments, one on each of two files.

@marcpaterno
Copy link
Collaborator

This is a comment added after pushing the "review" button.

Copy link
Collaborator

@marcpaterno marcpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test of the "request changes" choice for the "Finish your review" control.

@vitenti vitenti marked this pull request as ready for review October 6, 2022 13:44
@vitenti vitenti merged commit 256e994 into master Oct 6, 2022
@vitenti vitenti deleted the 183-state-control branch October 6, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State control for updatable objects
2 participants