Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable checkpoint file deletion for Run2.0i #167

Merged

Conversation

jchiang87
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.889% when pulling 3f87afc on u/jchiang/disable_ckpt_file_cleanup_for_Run2.0i into ea6e116 on dc2_run2.0_rc.

Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, since I think we tested this behavior in the original PR a long time ago.

@jchiang87 jchiang87 merged commit 8507c25 into dc2_run2.0_rc Sep 17, 2018
@jchiang87 jchiang87 deleted the u/jchiang/disable_ckpt_file_cleanup_for_Run2.0i branch September 17, 2018 05:12
@cwwalter
Copy link
Member

I think we want this not to go into master, so we should remember to make this change if we wind up just merging this release branch with all these changes to master. I'll make a note on the issue where we are tracking all the PRs that went into the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants