use lsst.obs.lsst.imsim.ImsimMapper instead of LsstCamMapper #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwwalter
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
This all looks good to me and ready to merge. Thanks.
I'm not sure if I could follow the changes carefully on amp_index etc in apply_crosstalk since I am not conversant in the new obs_lsst package yet ,but if the zip statement works (which I'm sure it does) it looks fine.
I think the unit test is checking metadata / geometry etc. It's seems hard to actually test it, but would there be some way of testing if the x-talk parameters are being used as anticipated in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and modify the crosstalk code to use the LSST Stack convention for the xtalk coefficients.