Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing AssertionError by matching the dsps_sed_demo.ipynb notebook to rail_dsps #140

Merged
merged 2 commits into from
May 11, 2024

Conversation

torluca
Copy link
Contributor

@torluca torluca commented May 10, 2024

Fixing AssertionError by matching the dsps_sed_demo.ipynb notebook to the one in rail_dsps. Refactoring of plotting_interface_skysim_cosmoDC2_COSMOS2020_demo.ipynb to directly curl downsampled catalogues from the web repository.

… the one in rail_dsps. Refactoring of plotting_interface_skysim_cosmoDC2_COSMOS2020_demo.ipynb to directly curl downsampled catalogues from the web repository.
@torluca torluca linked an issue May 10, 2024 that may be closed by this pull request
@torluca torluca requested a review from ztq1996 May 10, 2024 15:57
@torluca torluca self-assigned this May 10, 2024
@torluca torluca added the bug Something isn't working label May 10, 2024
Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goos

@ztq1996 ztq1996 merged commit eb71f47 into main May 11, 2024
9 checks passed
@ztq1996 ztq1996 deleted the 139-assertionerror-in-dsps_sed_demo branch May 20, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in dsps_sed_demo
2 participants