Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing smoke test failures #152

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

OliviaLynn
Copy link
Member

Problem & Solution Description (including issue #)

Should fix the rail smoke test failures (when all the following conditions are completed)

Context:

The canary in the mine was Useful_Utilities, which was failing with NameError: name 'RailStage' is not defined at this point in this run.

Main change: RailStage import

  • RailStage is now accessed via rail.core.stage.RailStage (previously rail.core.RailStage)
  • We don't seem to get RailStage when we run import_and_attach_all anymore
  • There could be some way to still get this, but for the time being, I think it should be fine to access RailStage via rail.core.stage.RailStage or import it as from rail.core.stage import RailStage or such

Also: ceci pre-v2 rollback

  • I've temporarily added a step to the smoke_test workflow to roll back ceci to be pre-v2, as that introduced a new error to the mix today (and Joe has said we shouldn't be using ceci v2 yet)
  • I don't mind a different strategy for this, but figured pinning a pre-v2 version in the dependencies would require us to roll out a new release, which would get in the way of things. I'm making/self-assigning Self-Memo: check ceci status and remove rollback step when appropriate #151 on my radar.

Finally: PZFlow import

@OliviaLynn OliviaLynn requested a review from ztq1996 July 10, 2024 22:15
Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for catching the error

@jlvdb
Copy link

jlvdb commented Jul 11, 2024

I should have pointed this out here directly, you could also add a line to pyproject.toml which says

ceci!=2.0

which avoids the issue with remembering to switch back to the latest version.

@hangqianjun
Copy link
Contributor

We are working on updating everything to ceci v2 now. This PR (LSSTDESC/rail_base#132) should hopefully resolve the problem without making changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants