Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pzflow to pzflow_nf in import #14

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update pzflow to pzflow_nf in import #14

merged 1 commit into from
Jul 15, 2024

Conversation

OliviaLynn
Copy link
Member

In my local environment, this fixed pzflow-related import error when running rail.stages.import_and_attach_all()

Will hopefully address a similar pzflow-related error when running Useful_Utilities.ipynb in the rail smoke test

@OliviaLynn
Copy link
Member Author

The KeyError: 'aliases' is something I've seen elsewhere in RAIL today, in relation to the new ceci v2 release. I am assuming that is what is causing the unit test failures here.

Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@torluca
Copy link
Contributor

torluca commented Jul 15, 2024

Qianjun and I will merge this pull request. The aliases problem is because of ceci v2 as Olivia already pointed out. This is an issue that is presenting itself in different packages and will be fixed for each and every one since ceci v2 is still in development.

@torluca torluca merged commit 2d3c540 into main Jul 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants