Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy<2.0.0 #140

Merged
merged 1 commit into from
Jul 30, 2024
Merged

numpy<2.0.0 #140

merged 1 commit into from
Jul 30, 2024

Conversation

ztq1996
Copy link
Contributor

@ztq1996 ztq1996 commented Jul 29, 2024

Restrict numpy to <2.0.0 for now before the pandas people fix their dtype error

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (e7bb3d4) to head (06bad71).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          43       43           
  Lines        2343     2343           
=======================================
  Hits         2305     2305           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eacharles eacharles self-requested a review July 30, 2024 18:42
@ztq1996 ztq1996 merged commit aa7a075 into main Jul 30, 2024
7 checks passed
@ztq1996 ztq1996 deleted the tqz/numpy_version branch August 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants