magnorm fix #98
Merged
magnorm fix #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| # Compute the flux density from magnorm in units of erg/cm^2/s/nm. | ||
| fnu = (magnorm * u.ABmag).to_value(u.erg/u.s/u.cm**2/u.Hz) | ||
| flambda = fnu * (astropy.constants.c/wl**2).to_value(u.Hz/u.nm) |
There was a problem hiding this comment.
Why is wl squared here?
There was a problem hiding this comment.
It's because flambda = fnu * (nu / wl) and nu = c / wl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more reliable way to set the SED normalization using the magnorm value, and it also fixes the mismatch between flux calculations for stars when using galsim 2.4.8 vs 2.5.1+.
I also simplified the
BaseObject._get_sedinterface since passing back magnorm is no longer needed (and in most cases, that value was being ignored anyway).