Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 add functionality to use input iterator in rail for parquet files #88

Conversation

joselotl
Copy link
Collaborator

@joselotl joselotl commented Dec 2, 2023

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@joselotl joselotl linked an issue Dec 2, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5fcae2) 100.00% compared to head (4076457) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          658       673   +15     
=========================================
+ Hits           658       673   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joselotl
Copy link
Collaborator Author

joselotl commented Dec 2, 2023

I added some functions to solve bug report LSSTDESC/rail#116 as well as LSSTDESC/rail_bpz#42

I don't know why it is reporting a change in coverage, I added the apropiate tests to the new functions

@eacharles
Copy link
Collaborator

There were two test functions with the same name. Also added a test for an unsupported file type, should be at 100% coverage now.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixed a name collision in tests.

@eacharles eacharles merged commit 97ad844 into main Feb 5, 2024
8 checks passed
@eacharles eacharles deleted the 87-add-functionality-to-use-input-iterator-in-rail-for-parquet-files branch May 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to use input iterator in Rail for Parquet files
2 participants