Add Linux Support #13
Conversation
…e() to return a command list instead
|
Great addtion! I would like to see that merged, because I'm a linux user. I assume however, that It might be tough to bench wine games. |
|
On the contrary, it should be pretty similar to benching them on Windows, we have access to the filesystem for logs and config files, and can send the contents of the screen to the markbench image recognition server in the same manner. If worse comes to worse, we could even install python into the wine environment and run markbench itself under wine. In fact, it might be easier to bench under wine, because you can easily automate the installation of dependencies into the environment through winetricks whereas on Windows it would either be a manual process or require custom download scripts |
|
|
||
| def exec_steam_run_command(game_id: int, steam_path=None) -> Popen: | ||
| if os.name == 'nt': |
There was a problem hiding this comment.
I would remove this nt section entirely for get_app_install_location. Is I pointed out in #44, it can't be counted on reliably unlike the other method which should be OS-agnostic
|
BTW @AutonomicPerfectionist if you don't have Cyberpunk by Feb 16 let me know and I got you |
|
@rcmaehl I'm going to look into that as well. I'm relatively good in Python and I have Cyberpunk to test with. But don't count on me, as I'm quite busy at the moment and I don't know when I'll have time to work on that. |
|
Any updates? |
|
Apologies, I got wrapped up in my research. I had started fixing merge conflicts some time ago but found that the CS:GO/2 test was disabled due to Valve not enabling scripting support in the release build of CS:2. However, I had recalled that I was able to get it working when it first released, and was going to look into what I did and whether it could be used to reenable the test here. That's when I got very busy unfortunately. I haven't looked at this repo in a very long time, but if this is still a desired PR I may be able to fix it up sometime after late August, I will likely be busy with research until then |
|
Thank you for the information. If possible, I would greatly appreciate an update on this PR. Of course, I understand that this is not your priority, but if you have the time and inclination to fix it, I would greatly appreciate it. |
This PR adds initial Linux support to these test harnesses.
Not all harnesses and features will work on Linux, to be clear. So far, I have the CS:GO benchmark working up until the game start detection. Since CS:GO recently was updated to CS:2, there is no longer a News icon for Markbench to detect, so it hangs there. I commented out those lines locally, and it proceeded further, making it into the map automatically and attempting to start the benchmark. The benchmark command was not found, but I verified the files were copied to the correct location, so it may have something to do with the recent update.
TODO
Note
I understand you are not accepting contributions at this time. However, I felt it was important for the Linux gaming community to add support as quickly as possible. Even if these changes are not merged, having these harnesses working on Linux gives us a jumping-off point for making the rest of Markbench work on Linux, once it is released.