Issue #44567: Hide scannable option for floating point fields due to improper matching. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Dec 28, 2021
| scannable={field.scannable} | ||
| appPropertiesOnly={appPropertiesOnly} | ||
| showScannableOption={domainFormDisplayOptions?.showScannableOption} | ||
| ////Issue #44567: Hide scannable option due to matching issues with floating point representation. |
There was a problem hiding this comment.
Hmm...I'm torn on if these commented out lines should stay in the code or not. I assume the reason to leave them is incase we ever decide to go back on this. I think just putting the issue number comment here is enough as that should lead to the issue tracker which will have the PR link.
There was a problem hiding this comment.
I think I'll leave the comment and make the showScannableOption={false} explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=44567
Hiding the scannable option due to mismatch between floating point representation and expected value
Related Pull Requests
Changes