Issue 44709 (leave modal open while adding uniqueIds) and add search usage metric #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XingY
reviewed
Mar 29, 2022
| @@ -787,9 +787,10 @@ class SampleTypeDesignerImpl extends React.PureComponent<Props & InjectedBaseDom | |||
| title={'Updating Sample Type with Unique ID field' + (numNewUniqueIdFields !== 1 ? 's' : '')} | |||
| onCancel={this.onUniqueIdCancel} | |||
There was a problem hiding this comment.
what happens when user click Cancel while the action is in progress? Should cancel be disabled when submitting?
There was a problem hiding this comment.
Yeah, I considered that. Currently, the Cancel button does not get disabled, so the effect is not actually cancelling but closing the modal. I think it makes sense to also disable the Cancel when submitting, but I'll check on usages.
XingY
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Adding unique IDs to existing samples can take a while if there are lots of samples, so we'll leave the modal open, disable the "Finish" button, and update its text to indicate that something is happening.
We also want to gather some usage data on the general search page usage, so we've added a per-product client-side usage counter.
Related Pull Requests
https://github.com/LabKey/sampleManagement/pull/898
#789
https://github.com/LabKey/biologics/pull/1219
Changes