Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miscellaneous issues #2129

Merged
merged 4 commits into from
Mar 27, 2021
Merged

Fix miscellaneous issues #2129

merged 4 commits into from
Mar 27, 2021

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Mar 26, 2021 •
edited
Loading

Rationale

Issue 42690: ChangeEmailAction comments and error messages reference "reset password"
Issue 41879: FormulaParseException from org.labkey.api.reader.ExcelFactory.getCellStringValue()

Also, Admin Console navtrails needed a bit more love

Changes

  • Correct, consistent Admin Console / Modules navtrails for create/delete/update module actions
  • Admin Console navtrail for site-wide terms of use page
  • Remove deprecated addAdminNavTrail() method

@labkey-adam labkey-adam mentioned this pull request Mar 26, 2021
Merged
@labkey-adam labkey-adam merged commit ec012e2 into develop Mar 27, 2021
@labkey-adam labkey-adam deleted the fb_misc_issues branch March 27, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

@labkey-klum labkey-klum Awaiting requested review from labkey-klum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-adam @labkey-jeckels