Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement start date alignment for input raster series #178

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Mar 15, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • Added alignment parameter to SimulationPeriod constructor;
  • The alignment date must be before or equal to the start date;
  • When an alignment date is not defined the start date will be used as the alignment;
  • Added optional configuration key alignment to section SIM_TIME of the configuration scheme.

Related Issue

Motivation and context

How has this been tested

  • Manual testing was performed by:
    • Setting the optional configuration key alignment int section SIM_TIME of the configuration file;
    • Executing RUBEM with provided sample dataset using the configuration file of the previous step;
    • Verifying the output against expected results;
  • Automated tests (unit and integration), including CLI integration tests added in this branch, must pass without exception.

Screenshots

  • N/A

@soaressgabriel soaressgabriel self-assigned this Mar 15, 2024
@soaressgabriel soaressgabriel linked an issue Mar 15, 2024 that may be closed by this pull request
@soaressgabriel soaressgabriel marked this pull request as ready for review March 15, 2024 20:44
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results match!

@soaressgabriel soaressgabriel merged commit 7402de2 into main Mar 20, 2024
4 checks passed
@soaressgabriel soaressgabriel deleted the feature/155-implement-start-date-alignment-for-input-raster-series branch March 20, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement start date alignment for input raster series
2 participants