Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest.json #1052

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Update manifest.json #1052

merged 8 commits into from
Apr 11, 2024

Conversation

Kallecrafter
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@Kallecrafter
Copy link
Contributor Author

json converter sagt mir das alles okay ist. Github macht wieder Probleme und ich hab null ahnung woran das liegen sollte.

github-actions[bot]
github-actions bot previously requested changes Apr 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/craftergang/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Kallecrafter
Copy link
Contributor Author

.

Kallecrafter
Kallecrafter commented Apr 10, 2024
View reviewed changes
Copy link
Contributor Author

@Kallecrafter Kallecrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "Welt-Untergang" to "Untergang.
removed -> "BuildFFA" as GameMode.

Kallecrafter
Kallecrafter commented Apr 10, 2024
View reviewed changes
Copy link
Contributor Author

@Kallecrafter Kallecrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@DoJapHD DoJapHD merged commit c7d0125 into LabyMod:master Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD approved these changes

@github-actions GitHub Actions GitHub Actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kallecrafter @DoJapHD