Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnThePixel.net #692

Merged
merged 9 commits into from
Sep 30, 2023
Merged

Add OnThePixel.net #692

merged 9 commits into from
Sep 30, 2023

Conversation

Paranoia8972
Copy link
Contributor

@Paranoia8972 Paranoia8972 commented Sep 9, 2023 •
edited

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/onthepixel/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/onthepixel/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/onthepixel/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/onthepixel/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

  • Invalid url. URL has to start with https:// (social.web)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Invalid url. URL has to start with https:// (social.web)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@Paranoia8972 Paranoia8972 changed the title Add files via upload Add OnThePixel.net Sep 10, 2023
@Paranoia8972
Copy link
Contributor Author

Paranoia8972 commented Sep 22, 2023 •
edited

Website is up and running. This is ready to pull. Thanks for your review @JakobBruening !

@JakobBruening JakobBruening merged commit 053b4ff into LabyMod:master Sep 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions Awaiting requested review from github-actions[bot]

@JakobBruening JakobBruening Awaiting requested review from JakobBruening

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Paranoia8972 @JakobBruening