Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runetales #920

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Runetales #920

merged 3 commits into from
Jan 26, 2024

Conversation

Unerwarteter
Copy link
Contributor

@Unerwarteter Unerwarteter commented Jan 26, 2024 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

DoJapHD
DoJapHD requested changes Jan 26, 2024
View reviewed changes
minecraft_servers/runetales/background.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

minecraft_servers/runetales/background@2x.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

minecraft_servers/runetales/manifest.json Outdated
"de"
],
"social": {
"web": "https://runetales.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reach website

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

minecraft_servers/runetales/manifest.json Outdated
"web": "https://runetales.net"
},
"gamemodes": {
"WorldOfMinecraft": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON key has to be lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

minecraft_servers/runetales/manifest.json Outdated
},
"discord": {
"server_id": 974013720831361104,
"rename_to_minecraft_name": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reserved for partners; change to false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Unerwarteter
update
5e87226 
edited files
@DoJapHD DoJapHD merged commit 2618ff6 into LabyMod:master Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unerwarteter @DoJapHD