RequestServer: Use libcurl for HTTP and HTTPS downloads #1400
+351
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomekling
force-pushed
the
rs-libcurl
branch
from
02b6983
to
3536857
Compare
This replaces the use of our home-grown implementations inherited from SerenityOS.
This is not relevant anymore when we use CURL.
To prevent deadlocks when both IPC peers are trying to send to each other but both sides have too much in their buffer already, we now move the send operation to a secondary thread where it can block until the peer is able to handle it.
This makes a big difference on macOS, where the default buffer size for local sockets is 8 KiB. With bigger buffers, we don't have to block on IPC nearly as often.
awesomekling
force-pushed
the
rs-libcurl
branch
from
3536857
to
9b9023d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of our home-grown implementations inherited from SerenityOS.